Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email translationPath and docu #10171

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Sep 26, 2024

Fixes custom translation path feature for notifications service and corrects its documentation.

@mmattel
Copy link
Contributor

mmattel commented Sep 26, 2024

@kobergj grep -rn LC_MESSAGES in the services folder returns results in:
activitylog, userlog, notifications and graph.
Means that the change you made here possibly belongs also to the other services than notifocations.
I may be wrong though...

@kobergj
Copy link
Collaborator Author

kobergj commented Sep 26, 2024

@mmattel no. Other services work properly. Only notifications service had the issue

@mmattel
Copy link
Contributor

mmattel commented Sep 26, 2024

@mmattel no. Other services work properly. Only notifications service had the issue

Got it.
Beside technical, this then should be consistent to avoid confusion service_name.po. Just my 2c

Signed-off-by: jkoberg <jkoberg@owncloud.com>
Copy link

sonarcloud bot commented Sep 27, 2024

@kobergj kobergj merged commit 496a3e4 into owncloud:master Sep 27, 2024
4 checks passed
@kobergj kobergj deleted the FixEmailTranslations branch September 27, 2024 08:37
ownclouders pushed a commit that referenced this pull request Sep 27, 2024
@micbar micbar mentioned this pull request Oct 1, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants