Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change samesite settings for web #2019

Merged
merged 1 commit into from
May 6, 2021
Merged

change samesite settings for web #2019

merged 1 commit into from
May 6, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented May 5, 2021 •
edited

Related Issue

Motivation and Context

Changed SameSite settings to Strict for Web to prevent warnings in Firefox

How Has This Been Tested?

  • locally in Firefox

@update-docs
Copy link

update-docs bot commented May 5, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek marked this pull request as ready for review May 5, 2021 11:12
kulmann
kulmann requested changes May 5, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You edited in the wrong changelog file after copying ;-)
Header looks good 👍

kulmann
kulmann approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wkloucek wkloucek requested a review from kulmann May 5, 2021 11:21
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit 385b1d4 into master May 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the samesite branch May 6, 2021 05:35
ownclouders pushed a commit that referenced this pull request May 6, 2021
@wkloucek
commit 385b1d4
66ede3d 
Merge: 5ab65b3 63cea30
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Thu May 6 07:35:43 2021 +0200

    Merge pull request #2019 from owncloud/samesite

    change samesite settings for web
@renovate renovate bot mentioned this pull request Jun 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loads of cookies + same-site cookie warnings in oCIS
2 participants
@wkloucek @kulmann