add max size and max num to the archiver capabilities

[wkloucek]

needs cs3org/reva#2106
fixes #2537

Archiver capabilites section:

          "archivers": [
            {
              "enabled": true,
              "version": "2.0.0",
              "formats": [
                "tar",
                "zip"
              ],
              "archiver_url": "/archiver",
              "max_num_files": "10000",
              "max_size": "1073741824"
            }
          ],

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[prohtex]

@wkloucek would you mind explaining why the archive limit exists? We routinely download 20GB and larger archives from our OC10 instance and it would be helpful to know about the failures that were mentioned with the archiver and large files. 1GB is very small for our purposes. Thank you!

[wkloucek]

hi @prohtex, please note that this PR didn't add the limit itself. It only reflected it in the capabilities endpoint so that clients (Web, Desktop, ...) actually have a chance to know where the limits are.

The limits are actually applied here: https://github.com/cs3org/reva/blob/51581ffa5f0c93ebd4f1d9d1f0a094d66c2a381f/internal/http/services/archiver/manager/archiver.go#L128-L141

These limits originate from cs3org/reva#1698 / cs3org/reva#2066 and to be honest I don't know the rationale behind it.

Actually I see no reason to not have a "unlimited" option here like 0 or -1 (but you cannot configure this currently). Could you please create a feature request issue on the owncloud/ocis repository for this?

[prohtex]

hi @prohtex, please note that this PR didn't add the limit itself. It only reflected it in the capabilities endpoint so that clients (Web, Desktop, ...) actually have a chance to know where the limits are.

The limits are actually applied here: https://github.com/cs3org/reva/blob/51581ffa5f0c93ebd4f1d9d1f0a094d66c2a381f/internal/http/services/archiver/manager/archiver.go#L128-L141

These limits originate from cs3org/reva#1698 / cs3org/reva#2066 and to be honest I don't know the rationale behind it.

Actually I see no reason to not have a "unlimited" option here like 0 or -1 (but you cannot configure this currently). Could you please create a feature request issue on the owncloud/ocis repository for this?

Hi @wkloucek thank you for your reply. I will make the request. So I understand though, there is a backend limit parameter, and one for Web as well? What I saw in the discussions was that archive creation was failing and the capability was added to prevent the failed archives.