Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send the space type in the cs3 Request #2583

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Send the space type in the cs3 Request #2583

merged 2 commits into from
Oct 6, 2021

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Oct 6, 2021 •
edited
Loading

Description

  • Graph API Enhancements
  • We should pass on the space type to the cs3api when creating a storage space

Reva

@micbar micbar requested review from refs and butonic October 6, 2021 11:58
@micbar micbar force-pushed the graph-use-type branch 2 times, most recently from 6012b53 to 6c50d6c Compare October 6, 2021 12:01
@micbar micbar requested a review from C0rby October 6, 2021 12:03
@ownclouders
Copy link
Contributor

💥 Acceptance tests Core-API-Tests-ocis-storage-5 failed. The build is cancelled...

butonic
butonic requested changes Oct 6, 2021
View reviewed changes
graph/pkg/service/v0/drives.go Outdated Show resolved Hide resolved
@micbar micbar requested a review from butonic October 6, 2021 12:45
@micbar
Copy link
Contributor Author

micbar commented Oct 6, 2021

@C0rby 🎉 Your fixes from reva are also sucked in.

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@butonic butonic merged commit 8b416c9 into master Oct 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the graph-use-type branch October 6, 2021 14:16
ownclouders pushed a commit that referenced this pull request Oct 6, 2021
@butonic
commit 8b416c9
66e7c41 
Merge: 21acef4 84bc009
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Wed Oct 6 16:16:46 2021 +0200

    Merge pull request #2583 from owncloud/graph-use-type

    Send the space type in the cs3 Request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@refs refs Awaiting requested review from refs

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micbar @ownclouders @butonic