Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce hacky reference handling in thumbnailer #3669

Merged
merged 1 commit into from
May 4, 2022
Merged

reduce hacky reference handling in thumbnailer #3669

merged 1 commit into from
May 4, 2022

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented May 4, 2022 •
edited

Fix thumbnails requests with full spaces reference (<providerid>$<spaceid>!<nodeid>).

@C0rby C0rby requested review from butonic, micbar and kobergj May 4, 2022 08:54
@C0rby C0rby self-assigned this May 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@C0rby C0rby merged commit da1abdb into master May 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the thumbnails-fix branch May 4, 2022 09:34
ownclouders pushed a commit that referenced this pull request May 4, 2022
commit da1abdb
58fc6ba 
Merge: a22cfe6 ae9aff3
Author: David Christofas <dchristofas@owncloud.com>
Date:   Wed May 4 11:34:53 2022 +0200

    Merge pull request #3669 from owncloud/thumbnails-fix

    reduce hacky reference handling in thumbnailer
@micbar micbar mentioned this pull request May 10, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@kobergj kobergj kobergj approved these changes

@micbar micbar Awaiting requested review from micbar

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@C0rby @butonic @kobergj