Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Remove glauth and accounts services #3685

Merged
merged 6 commits into from
May 11, 2022

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented May 5, 2022

Todo:

  • Rework ocs tests to use cs3 instead of accounts
  • Remove remaining mentions of accounts and glauth from docs (or create issues)

@update-docs
Copy link

update-docs bot commented May 5, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic
Copy link
Member

butonic commented May 5, 2022

if we drop glauth we would need a way to set up an ocis instance with the built in IDP thet reads the users from an existing owncloud instance. We could add a cs3 backend to LibreIDM, or even an owncloudsql or maybe even generic sql backend.

@rhafer rhafer force-pushed the accounts-glauth-rm branch 4 times, most recently from ab49383 to 27b4d50 Compare May 10, 2022 11:43
@rhafer rhafer changed the title Remove glauth and accounts services [full-ci] Remove glauth and accounts services May 10, 2022
@rhafer rhafer marked this pull request as ready for review May 10, 2022 12:44
@rhafer
Copy link
Contributor Author

rhafer commented May 10, 2022

if we drop glauth we would need a way to set up an ocis instance with the built in IDP thet reads the users from an existing owncloud instance. We could add a cs3 backend to LibreIDM, or even an owncloudsql or maybe even generic sql backend.

Actually our IDP (lico) actually even has a libregraph identity backend (https://github.com/libregraph/lico/blob/master/identifier/backends/libregraph/libregraph.go), might be possible to enhance that to work with our graph service.

- proxy routes everything user/group related (except of `user/signing-key`)
  to the reva ocs endpoint now
- remove the unused user and group methods from ocs
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

3.0% 3.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@rhafer rhafer merged commit a7bc738 into owncloud:master May 11, 2022
@micbar micbar mentioned this pull request May 25, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants