add description tags to thumbnails config #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great 👍 As more you fix, also in other extensions, as better 😄 |
|
💥 Acceptance test cs3ApiTests-ocis failed. Further test are cancelled... |
|
Kudos, SonarCloud Quality Gate passed! |
kobergj
approved these changes
May 10, 2022
|
Thanks a lot 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added description tags to the config structs in the thumbnails service so they will be included in the config documentation.
/cc @mmattel
@wkloucek, there is a
TransferSecretin the thumbnails service which got the value of theRevaTransferSecret. I changed that because this thumbnails transfer secret has nothing to do with Reva. Do I need to update anything else because of this? Like deployment examples or docs?