Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] update reva to v2.4.2-0.20220601110755-6b47effc3759 #3853

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

butonic
Copy link
Member

@butonic butonic commented May 23, 2022

@update-docs
Copy link

update-docs bot commented May 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic self-assigned this May 23, 2022
@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@butonic butonic changed the title test filter mask [full-ci] test filter mask May 24, 2022
@butonic butonic changed the title [full-ci] test filter mask [tests-only] [full-ci] test filter mask May 24, 2022
@butonic butonic force-pushed the test-filter-mask branch 5 times, most recently from d4c2eb5 to e78eb8f Compare May 30, 2022 09:02
@butonic butonic changed the title [tests-only] [full-ci] test filter mask [full-ci] test filter mask May 30, 2022
@butonic butonic changed the title [full-ci] test filter mask [full-ci] update reva May 30, 2022
@butonic butonic changed the title [full-ci] update reva [full-ci] update reva to v2.4.2-0.20220530084041-036e520a0010 May 30, 2022
@butonic butonic marked this pull request as ready for review May 30, 2022 09:04
@micbar
Copy link
Contributor

micbar commented May 30, 2022

One unexpected fail, one unexpected pass.

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/12165/37/6
apiSpaces/changeSpaces.feature:138 now passes - space quota can be set to "0" and has the effect of setting "unlimited" quota. Looks like "a good thing".

https://drone.owncloud.com/owncloud/ocis/12165/46/6
apiVersions/fileVersions.feature:496 failed:

  Scenario: User cannot retrieve meta information of a file which is owned by somebody else    # /srv/app/testrunner/tests/acceptance/features/apiVersions/fileVersions.feature:496
    Given user "Brian" has been created with default attributes and without skeleton files     # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Alice" has uploaded file with content "123" to "/davtest.txt "                   # FeatureContext::userHasUploadedAFileWithContentTo()
    And we save it into "FILEID"                                                               # FeatureContext::saveItInto()
    When user "Brian" retrieves the meta information of fileId "<<FILEID>>" using the meta API # FilesVersionsContext::userGetMetaInfo()
    Then the HTTP status code should be "404"                                                  # FeatureContext::thenTheHTTPStatusCodeShouldBe()
      HTTP status code 207 is not the expected value 404
      Failed asserting that 207 matches expected '404'.

That gave a 207 HTTP multi-status response rather than a 404. I wonder if/why it passed in reva edge?

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic changed the title [full-ci] update reva to v2.4.2-0.20220530084041-036e520a0010 [full-ci] update reva to v2.4.2-0.20220601110755-6b47effc3759 Jun 1, 2022
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/12222/37/6

runsh: There were no unexpected failures.
runsh: Total unexpected passed scenarios throughout the test run:
apiSpaces/changeSpaces.feature:138

Remove that from expected-failures and this PR should pass CI.

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic
Copy link
Member Author

butonic commented Jun 1, 2022

fixes #3810

@phil-davis phil-davis merged commit cbdcb27 into master Jun 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the test-filter-mask branch June 1, 2022 13:09
ownclouders pushed a commit that referenced this pull request Jun 1, 2022
Merge: ed71d78 fcf2f1e
Author: Phil Davis <phil@jankaritech.com>
Date:   Wed Jun 1 18:54:13 2022 +0545

    Merge pull request #3853 from owncloud/test-filter-mask

    [full-ci] update reva to v2.4.2-0.20220601110755-6b47effc3759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants