Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate shares #3987

Merged
merged 5 commits into from
Jun 21, 2022
Merged

Migrate shares #3987

merged 5 commits into from
Jun 21, 2022

Conversation

aduffeck
Copy link
Contributor

Description

This PR adds a migrate command to the ocis cli with subcommands for migrating shares and public shares between providers.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 20, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Jun 20, 2022 •
edited
Loading

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@aduffeck aduffeck force-pushed the migrate-shares branch 4 times, most recently from 6a3ab6f to 158e4ac Compare June 21, 2022 09:31
kobergj
kobergj requested changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking...

ocis/pkg/command/migrate.go Outdated Show resolved Hide resolved
ocis/pkg/command/migrate.go Outdated Show resolved Hide resolved
ocis/pkg/command/migrate.go Outdated Show resolved Hide resolved
ocis/pkg/command/migrate.go Show resolved Hide resolved
ocis/pkg/command/migrate.go Outdated Show resolved Hide resolved
ocis/pkg/command/migrate.go Show resolved Hide resolved
ocis/pkg/command/migrate.go Outdated Show resolved Hide resolved
ocis/pkg/command/migrate.go Outdated Show resolved Hide resolved
kobergj
kobergj approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
14.4% 14.4% Duplication

@micbar micbar merged commit 5c8eeb3 into owncloud:master Jun 21, 2022
ownclouders pushed a commit that referenced this pull request Jun 21, 2022
@micbar
commit 5c8eeb3
e07aa87 
Merge: 275b551 54c3523
Author: Michael Barz <mbarz@owncloud.com>
Date:   Tue Jun 21 16:23:32 2022 +0200

    Merge pull request #3987 from aduffeck/migrate-shares

    Migrate shares
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduffeck @ownclouders @butonic @kobergj @micbar