Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add index.html to unprotected paths in auth middleware #4458

Merged
merged 2 commits into from
Aug 25, 2022
Merged

fix: add index.html to unprotected paths in auth middleware #4458

merged 2 commits into from
Aug 25, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Aug 25, 2022 •
edited
Loading

Description

When ownCloud Web uses the vue router hash mode we need /index.html#/whatever-ruotes to be unprotected as well.

open with web internally resolves into /external, so I needed to shorten the unprotected path prefix /external/spaces to /external.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann requested a review from C0rby August 25, 2022 08:41
@kulmann kulmann self-assigned this Aug 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann merged commit 79f7d64 into master Aug 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the more-unprotected-paths branch August 25, 2022 11:08
ownclouders pushed a commit that referenced this pull request Aug 25, 2022
@kulmann
commit 79f7d64
107b80d 
Merge: bbca91b 9d67ab3
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Thu Aug 25 13:08:44 2022 +0200

    Merge pull request #4458 from owncloud/more-unprotected-paths
@kulmann kulmann mentioned this pull request Aug 25, 2022
Closed
29 tasks
ownclouders pushed a commit that referenced this pull request Aug 25, 2022
@kulmann
commit 79f7d64
b199fe5 
Merge: bbca91b 9d67ab3
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Thu Aug 25 13:08:44 2022 +0200

    Merge pull request #4458 from owncloud/more-unprotected-paths
ownclouders pushed a commit that referenced this pull request Aug 25, 2022
@kulmann
commit 79f7d64
bbc2c94 
Merge: bbca91b 9d67ab3
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Thu Aug 25 13:08:44 2022 +0200

    Merge pull request #4458 from owncloud/more-unprotected-paths
ownclouders pushed a commit that referenced this pull request Aug 25, 2022
@kulmann
commit 79f7d64
7b68ac2 
Merge: bbca91b 9d67ab3
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Thu Aug 25 13:08:44 2022 +0200

    Merge pull request #4458 from owncloud/more-unprotected-paths
@kulmann kulmann mentioned this pull request Aug 26, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @C0rby