[full-ci] add missing cors config #5988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbar
force-pushed
the
add-more-cors
branch
2 times, most recently
from
e9b23ff
to
1ced549
Compare
|
@mmattel I added defaults and descriptions. Most parts were "just missing" |
|
@LukasHirt I think that unblocks the filepicker integration. |
mmattel
approved these changes
Apr 3, 2023
wkloucek
approved these changes
Apr 3, 2023
Awesome, thanks! I'll give it a shot once it's ready to confirm it |
|
E2E tests failed: https://drone.owncloud.com/owncloud/ocis/21079/88/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/21079/tracing/folder-alice-2023-4-3-03-44-39.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/21079/tracing/folder-brian-2023-4-3-03-44-52.zip |
|
Kudos, SonarCloud Quality Gate passed!
|
ownclouders
pushed a commit
that referenced
this pull request
Apr 3, 2023
[full-ci] add missing cors config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Add missing CORS config
The graph, userlog and ocdav services had no CORS config options.
Reva Part: cs3org/reva#3764