Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and improve the caching config #6148

Merged
merged 5 commits into from
Apr 27, 2023
Merged

Conversation

aduffeck
Copy link
Contributor

@aduffeck aduffeck commented Apr 26, 2023

Add to the cache config cleanup. Also fix passing on the ttls to reva (need to be passed as seconds, not nanoseconds).

Depends on cs3org/reva#3820

Fixes #6129

/cc @butonic @mmattel

@update-docs
Copy link

update-docs bot commented Apr 26, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@mmattel
Copy link
Contributor

mmattel commented Apr 26, 2023

With regards to OCIS_CACHE_TTL
When looking to the global list of services that use the ttl, are all occurences fixed/ok?

@ownclouders
Copy link
Contributor

ownclouders commented Apr 26, 2023

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

butonic and others added 4 commits April 26, 2023 15:50
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@butonic
Copy link
Member

butonic commented Apr 27, 2023

ignoring sonarcloud: package-comments: should have a package comment

@butonic butonic merged commit 1294892 into owncloud:master Apr 27, 2023
ownclouders pushed a commit that referenced this pull request Apr 27, 2023
* Cleanup and improve the caching config

* bump reva

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* disable stat cache

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* Bump reva

* Linter fixes

---------

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
fschade pushed a commit that referenced this pull request Jul 10, 2023
* Cleanup and improve the caching config

* bump reva

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* disable stat cache

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* Bump reva

* Linter fixes

---------

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCIS_CACHE_TTL reports in one service a default of 300ns
4 participants