-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] allow to disable previews in webdav & web #6577
[full-ci] allow to disable previews in webdav & web #6577
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Christian Richter <crichter@owncloud.com>
7f250d0
to
b3fd53d
Compare
Signed-off-by: Christian Richter <crichter@owncloud.com>
5f2e368
to
a63931a
Compare
💥 Acceptance test Core-API-Tests-ocis-storage-7 failed. Further test are cancelled... |
💥 Acceptance test Core-API-Tests-ocis-storage-3 failed. Further test are cancelled... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit surprised by thise change. The web option only prevents thumbnails in order to give the possibility to speed up the file list rendering. It does not block previews in the right sidebar details panel. And most importantly the "preview" app which is responsible for rendering media files in a single folder also uses the thumbnail service (using higher resolutions) to render the images relatively big and with high resolution.
Disabling the thumbnail service alltogether seems a little too much for me. Also, I don't share the expected behaviour in the ticket.
Signed-off-by: Christian Richter <crichter@owncloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just some description suggestions. But @mmattel is more qualified to judge that 😉
Co-authored-by: kobergj <juliankoberg@googlemail.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: kobergj <juliankoberg@googlemail.com>
Kudos, SonarCloud Quality Gate passed! |
[full-ci] allow to disable previews in webdav & web
We added an env var
OCIS_DISABLE_PREVIEWS
to disable the thumbnails for web & webdav via a global setting.For each service this behaviour can be disabled using the local env vars
WEB_OPTION_DISABLE_PREVIEWS
(old)and
WEBDAV_OPTION_DISABLE_PREVIEWS
(new).refs #192