Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] Add tus upload documentation #7500

Merged
merged 3 commits into from
Nov 7, 2023
Merged

[docs-only] Add tus upload documentation #7500

merged 3 commits into from
Nov 7, 2023

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR add document related to api requestion to make tus upload

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Oct 16, 2023
@amrita-shrestha amrita-shrestha force-pushed the tus-upload-docs branch 2 times, most recently from 6c46790 to f5b753c Compare October 16, 2023 09:15
@mmattel
Copy link
Contributor

mmattel commented Oct 16, 2023

@EParzefall mind to have a look on it for a language review?

EParzefall
EParzefall reviewed Oct 16, 2023
View reviewed changes
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
EParzefall
EParzefall reviewed Oct 16, 2023
View reviewed changes
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha marked this pull request as ready for review October 17, 2023 07:06
KarunAtreya
KarunAtreya reviewed Oct 17, 2023
View reviewed changes
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
@saw-jan saw-jan requested a review from mmattel October 17, 2023 11:01
@micbar
Copy link
Contributor

micbar commented Oct 17, 2023

Good writeup in general.

EParzefall
EParzefall reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@EParzefall EParzefall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/helpers/extended_vars.yaml Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
individual-it
individual-it requested changes Oct 18, 2023
View reviewed changes
docs/helpers/extended_vars.yaml Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Show resolved Hide resolved
@individual-it individual-it mentioned this pull request Oct 18, 2023
Closed
5 tasks
@amrita-shrestha amrita-shrestha mentioned this pull request Oct 20, 2023
Merged
9 tasks
@amrita-shrestha amrita-shrestha force-pushed the tus-upload-docs branch 2 times, most recently from 6981b7c to 482b34c Compare October 20, 2023 06:33
individual-it
individual-it requested changes Oct 30, 2023
View reviewed changes
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
docs/apis/http/tus_upload.md Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the tus-upload-docs branch 2 times, most recently from d36a1ae to c26ff85 Compare November 3, 2023 03:53
@mmattel
Copy link
Contributor

mmattel commented Nov 3, 2023

@amrita-shrestha only some small improvements. You can collect them to a block and commit them at once.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmattel mmattel merged commit 7825e5e into master Nov 7, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tus-upload-docs branch November 7, 2023 15:27
ownclouders pushed a commit that referenced this pull request Nov 7, 2023
@mmattel
Merge pull request #7500 from owncloud/tus-upload-docs
adf6f67 
[docs-only] Add tus upload documentation
ownclouders pushed a commit that referenced this pull request Nov 8, 2023
@mmattel
Merge pull request #7500 from owncloud/tus-upload-docs
a97c2fb 
[docs-only] Add tus upload documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarunAtreya KarunAtreya KarunAtreya left review comments

@micbar micbar micbar left review comments

@mmattel mmattel mmattel approved these changes

@individual-it individual-it individual-it approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@saw-jan saw-jan Awaiting requested review from saw-jan

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@EParzefall EParzefall Awaiting requested review from EParzefall

Assignees

@amrita-shrestha amrita-shrestha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amrita-shrestha @mmattel @micbar @individual-it @EParzefall @KarunAtreya