filter user e-mail in graph/user requests #8764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Richter <crichter@owncloud.com>
dragonchaser
force-pushed
the
filter-user-email-in-results
branch
from
8850665
to
59fab4a
Compare
kobergj
approved these changes
Apr 3, 2024
rhafer
requested changes
Apr 3, 2024
services/graph/pkg/config/reva.go
Outdated
| @@ -2,5 +2,6 @@ package config | |||
|
|
|||
| // TokenManager is the config for using the reva token manager | |||
| type TokenManager struct { | |||
| JWTSecret string `yaml:"jwt_secret" env:"OCIS_JWT_SECRET;GRAPH_JWT_SECRET" desc:"The secret to mint and validate jwt tokens." introductionVersion:"pre5.0"` | |||
| JWTSecret string `yaml:"jwt_secret" env:"OCIS_JWT_SECRET;GRAPH_JWT_SECRET" desc:"The secret to mint and validate jwt tokens." introductionVersion:"pre5.0"` | |||
| ShowUserEmailInResults bool `yaml:"mask_user_email" env:"OCIS_SHOW_USER_EMAIL_IN_RESULTS" desc:"Mask user email addresses in responses." introductionVersion:"5.1"` | |||
There was a problem hiding this comment.
Why did you put the setting in the TokenManager struct. I don't think it should go there.
Wouldn't it better fit into config.API? See config.go
The same it true for the ocs service btw.
There was a problem hiding this comment.
Oh, if it is still for debate if we need this switch or not, I am team Ralf 😃
There was a problem hiding this comment.
I already adapted the code
Signed-off-by: Christian Richter <crichter@owncloud.com>
…r/ocis into filter-user-email-in-results
|
rhafer
approved these changes
Apr 3, 2024
ownclouders
pushed a commit
that referenced
this pull request
Apr 3, 2024
filter user e-mail in graph/user requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Mask user email in output
We have fixed a bug where the user email was not masked in the output and the user emails could be enumerated through
the sharee search. This is the ocis side which adds an suiting config option to mask user emails in the output.
refs #8726