Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] adding test for creating internal link share by the member of a project drive #9434

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[tests-only][full-ci] adding test for creating internal link share by the member of a project drive #9434

merged 1 commit into from
Jul 30, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Jun 21, 2024 •
edited
Loading

Description

adding test for creating internal link share by the member of a project drive

Scenario Outline: create an internal link share by a member of a project space drive using root endpoint
Scenario Outline: create an internal link share by a member of a project space drive using permissions endpoint
Scenario Outline: create an internal quick link share by a member of a project space drive using root endpoint
Scenario Outline: create an internal quick link share by a member of a project space drive using permissions endpoint
Scenario Outline: try to create an internal link share by a member of a project space drive with password using root endpoint
Scenario Outline: try to create an internal link share by a member of a project space drive with password using permissions endpoint

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1: locally
  • test case 2: ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Jun 21, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Jun 21, 2024
Closed
30 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nirajacharya2
Copy link
Contributor Author

nirajacharya2 commented Jul 8, 2024 •
edited
Loading

waiting for cs3org/reva#4633 to get merge

@nirajacharya2 nirajacharya2 force-pushed the internal-link-by-all-member-of-space branch from 97c029b to 22773e9 Compare July 30, 2024 04:29
@nirajacharya2 nirajacharya2 marked this pull request as ready for review July 30, 2024 05:35
@nirajacharya2 nirajacharya2 force-pushed the internal-link-by-all-member-of-space branch from 22773e9 to bde88b3 Compare July 30, 2024 05:37
@nirajacharya2 nirajacharya2 force-pushed the internal-link-by-all-member-of-space branch from bde88b3 to 4c50f6c Compare July 30, 2024 05:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ScharfViktor
ScharfViktor approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit c5a3027 into master Jul 30, 2024
4 checks passed
@saw-jan saw-jan deleted the internal-link-by-all-member-of-space branch July 30, 2024 08:12
ownclouders pushed a commit that referenced this pull request Jul 30, 2024
@saw-jan
Merge pull request #9434 from owncloud/internal-link-by-all-member-of…
f1198d4 
…-space

[tests-only][full-ci] adding test for creating internal link share by the member of a project drive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@SagarGi SagarGi Awaiting requested review from SagarGi

@saw-jan saw-jan Awaiting requested review from saw-jan

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirajacharya2 @ScharfViktor @saw-jan @micbar