Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activitylog fixes #9467

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Activitylog fixes #9467

merged 2 commits into from
Jun 27, 2024

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jun 25, 2024

Fixes multiple small activitylog issues:

  • understand ids of format uuid1$uuid2
  • return an empty list instead of null when there are no activities.
  • return messages even if resource/user/space got removed meanwhile
  • delete the document from the store when the corresponding item is purged
  • allow sorting result "asc" (default) or "desc" using the "sort" kql parameter

Signed-off-by: jkoberg <jkoberg@owncloud.com>
2403905
2403905 previously approved these changes Jun 26, 2024
@kobergj kobergj requested a review from 2403905 June 26, 2024 14:31
@kobergj kobergj dismissed 2403905’s stale review June 26, 2024 14:31

changes. needs reapprove.

@kobergj kobergj enabled auto-merge June 26, 2024 17:12
@micbar
Copy link
Contributor

micbar commented Jun 26, 2024

Something panics in the CI

goroutine 755 [running]:
github.com/owncloud/ocis/v2/services/activitylog/pkg/service.(*ActivitylogService).RemoveResource(0xc001eac1e0, 0x0)
	/drone/src/services/activitylog/pkg/service/service.go:231 +0x9d
github.com/owncloud/ocis/v2/services/activitylog/pkg/service.(*ActivitylogService).Run(0xc001eac1e0)
	/drone/src/services/activitylog/pkg/service/service.go:108 +0x39d
created by github.com/owncloud/ocis/v2/services/activitylog/pkg/service.New in goroutine 413
	/drone/src/services/activitylog/pkg/service/service.go:89 +0x4c7
2024/06/26 20:57:37 [ociswrapper] oCIS server exited with code 2
2024/06/26 20:57:37 [ociswrapper] Retry starting oCIS server... (retry 1)
2024/06/26 20:57:38 INFO memory is not limited, skipping package=github.com/KimMachineGun/automemlimit/memlimit
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1736e9d]

Signed-off-by: jkoberg <jkoberg@owncloud.com>
Copy link

sonarcloud bot commented Jun 27, 2024

@kobergj kobergj merged commit da03529 into owncloud:master Jun 27, 2024
3 checks passed
@kobergj kobergj deleted the ActivitylogFixes branch June 27, 2024 09:13
ownclouders pushed a commit that referenced this pull request Jun 27, 2024
@micbar micbar mentioned this pull request Jul 8, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants