Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more wopi features, language, disable chat #9580

Merged
merged 17 commits into from
Jul 12, 2024

Conversation

dragonchaser
Copy link
Member

@dragonchaser dragonchaser commented Jul 10, 2024

Description

Implementation of #9398
Related to #6540 (which was used in the former reva app provider)

Added Features

  • Disable Chat
  • Language params
    • lang (Collabora)
    • ui (OnlyOffice)
    • UI_LLCC (Office365)

https://learn.microsoft.com/en-us/microsoft-365/cloud-storage-partner-program/online/discovery#ui_llcc
https://api.onlyoffice.com/editors/wopi/discovery#ui
https://api.onlyoffice.com/editors/wopi/discovery#lang
https://sdk.collaboraonline.com/docs/advanced_integration.html#url-query-parameters

Tested

  • ✅ Disable Chat in ocis_full example with onlyoffice
  • ✅ Change Language in ocis_full example with onlyoffice
  • ✅ Change Language in ocis_full example with collabora

Copy link

update-docs bot commented Jul 10, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dragonchaser dragonchaser force-pushed the disable_collabora_chat branch 3 times, most recently from 0b83f34 to 1efd310 Compare July 11, 2024 14:01
dragonchaser and others added 7 commits July 11, 2024 21:19
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: Michael Barz <mbarz@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: Michael Barz <mbarz@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
@micbar micbar marked this pull request as ready for review July 11, 2024 20:03
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested it locally with Collabora and OnlyOffice

@micbar micbar changed the title disable collabora chat Add more wopi features, language, disable chat Jul 11, 2024
dragonchaser and others added 9 commits July 12, 2024 09:24
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: Michael Barz <mbarz@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: Michael Barz <mbarz@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Copy link

sonarcloud bot commented Jul 12, 2024

Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦇 🦇 🦇 wait we cant stop here, this is pointers country 🦇 🦇 🦇

@dragonchaser dragonchaser merged commit 7efff80 into owncloud:master Jul 12, 2024
4 checks passed
@dragonchaser dragonchaser deleted the disable_collabora_chat branch July 12, 2024 11:33
ownclouders pushed a commit that referenced this pull request Jul 12, 2024
Add more wopi features, language, disable chat
@micbar micbar mentioned this pull request Jul 30, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants