Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix idp config generation #9770

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix idp config generation #9770

merged 1 commit into from
Aug 9, 2024

Conversation

butonic
Copy link
Member

@butonic butonic commented Aug 9, 2024

We now use the OCIS_URL to generate the web client registration configuration. It does not make sense use the OCIS_ISSUER_URL if the idp was configured to run on a different domain.

the client config is correct:

			{
				ID:      "web",
				Name:    "ownCloud Web app",
				Trusted: true,
				RedirectURIs: []string{
					"{{OCIS_URL}}/",
					"{{OCIS_URL}}/oidc-callback.html",
					"{{OCIS_URL}}/oidc-silent-redirect.html",
				},
				Origins: []string{
					"{{OCIS_URL}}",
				},
			},

but we use the wrong variable to replace OCIS_URL

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Copy link

sonarcloud bot commented Aug 9, 2024

@butonic butonic enabled auto-merge August 9, 2024 12:21
@butonic butonic merged commit f4c3973 into master Aug 9, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Aug 9, 2024
@ScharfViktor ScharfViktor mentioned this pull request Aug 20, 2024
21 tasks
d7oc added a commit to owncloud/ocis-charts that referenced this pull request Sep 5, 2024
@wkloucek wkloucek deleted the idg-config-generation-fix branch September 6, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants