Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a file is not restored from trashbin if files with the same name already exists #1730

Closed
haribhandari07 opened this issue Aug 8, 2019 · 4 comments
Closed

a file is not restored from trashbin if files with the same name already exists #1730

haribhandari07 opened this issue Aug 8, 2019 · 4 comments
Labels
feature:files Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working

Comments

@haribhandari07
Copy link
Contributor

haribhandari07 commented Aug 8, 2019 •
edited
Loading

Steps to reproduce

  1. Create a file eg. file.txt
  2. Delete file.txt and create file.txt
  3. Restore file.txt

Expected behaviour

file.txt should be restored.

Actual behaviour

file.txt is not restored
@haribhandari07 haribhandari07 changed the title a file is not resotred from trashbin if file with the same name exists a file is not resotred from trashbin if files with the same name already exists Aug 8, 2019
@haribhandari07 haribhandari07 self-assigned this Aug 8, 2019
@haribhandari07 haribhandari07 added the Type:Bug Something isn't working label Aug 8, 2019
@haribhandari07 haribhandari07 removed their assignment Aug 9, 2019
@individual-it individual-it changed the title a file is not resotred from trashbin if files with the same name already exists a file is not restored from trashbin if files with the same name already exists Aug 9, 2019
@DeepDiver1975 DeepDiver1975 added the Priority:p2-high Escalation, on top of current planning, release blocker label Aug 16, 2019
@LukasHirt LukasHirt added this to the backlog milestone Aug 23, 2019
@LukasHirt LukasHirt removed this from the backlog milestone Sep 1, 2019
@LukasHirt LukasHirt self-assigned this Sep 1, 2019
@LukasHirt
Copy link
Collaborator

Hmm, seems like this will need change in the API. You'll probably need to take over here @DeepDiver1975 ?

@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Sep 24, 2019
@LukasHirt LukasHirt removed their assignment Sep 27, 2019
@PVince81
Copy link
Contributor

Like for the files drop feature we could add a "OC-Autorename" header that tells the server that we're ok with it renaming the target if a duplicate exists.

@PVince81 PVince81 mentioned this issue Oct 14, 2019
Closed
@individual-it individual-it mentioned this issue Feb 11, 2020
Closed
@PVince81 PVince81 mentioned this issue May 19, 2020
Closed
@kulmann kulmann added Priority:p1-urgent Consider a hotfix release with only that fix and removed Priority:p2-high Escalation, on top of current planning, release blocker labels Dec 3, 2021
@fschade
Copy link
Collaborator

fschade commented Mar 24, 2022

@tbsbdr please have a look, i tested it and think it's ok how web handles the case.

  • create file foo
  • delete file foo
  • create file foo
  • go to trash and restore foo

then ui shows an error (see screenshot).

alternatively web could show an option in thrashbin 'restore as'... but really not sure if it makes sense.
Bildschirmfoto 2022-03-24 um 14 56 48

@kulmann kulmann removed this from the Milestone 1: Phoenix for users milestone Oct 27, 2022
@AlexAndBear
Copy link
Contributor

Closing as we have a name collision dialog now and everything is working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature:files Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@PVince81 @DeepDiver1975 @kulmann @micbar @LukasHirt @AlexAndBear @haribhandari07 @fschade