Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite dialog wording #3047

Closed
PVince81 opened this issue Feb 17, 2020 · 5 comments · Fixed by #3050
Closed

Overwrite dialog wording #3047

PVince81 opened this issue Feb 17, 2020 · 5 comments · Fixed by #3050
Assignees
Labels
Category:Enhancement Add new functionality Topic:good-first-issue beginner friendly task

Comments

@PVince81
Copy link
Contributor

Steps

  1. Upload a file "test.txt"
  2. Upload it again

Expected

  • if versions app enabled, the text should say "Create new version"
  • otherwise it should say "Overwrite"

cc @pmaier1

@PVince81 PVince81 added Category:Enhancement Add new functionality Topic:good-first-issue beginner friendly task labels Feb 17, 2020
@LukasHirt LukasHirt self-assigned this Feb 17, 2020
@LukasHirt
Copy link
Collaborator

In product used to be written that when versioning is enabled it should create a new version directly without the confirmation. Was this changed or should I add a todo into the code? @pmaier1

@PVince81
Copy link
Contributor Author

If not too complex to do I guess we could go directly with the "no dialog prompt".

@kulmann
Copy link
Member

kulmann commented Feb 17, 2020

I would suppose that many users don't want to deal with the concept of versions (until they need it). So for easy UX the way to go would be, not to ask the user about it and just create the new version.

@LukasHirt
Copy link
Collaborator

LukasHirt commented Feb 17, 2020

If not too complex to do I guess we could go directly with the "no dialog prompt".

Well, if I remember correctly there were plans for some changes in the upload logic, weren't there? I think something about moving them to sdk. If it's still the plan then I'd prefer to implement some bigger changes afterwards.

@PVince81
Copy link
Contributor Author

Nice how GDrive does it, it does overwrite the files but shows a warning, and the upload popup gives you the option to still split the file:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality Topic:good-first-issue beginner friendly task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants