Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In slow networks requirejs reuquests can timeout. The timeout is set … #3293

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Apr 3, 2020

…not to a higher value (200 secs)

Description

How Has This Been Tested?

  • under test in a customer setup

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Apr 3, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 self-assigned this Apr 3, 2020
@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Apr 3, 2020
@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review April 3, 2020 12:29
@@ -0,0 +1,5 @@
Bugfix: Set a higher timeout for requirejs

In slow networks requirejs reuquests can timeout. The timeout is set not to a higher value (200 secs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in requests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and another one in now (being not instead of now)

@DeepDiver1975 DeepDiver1975 merged commit 4ef7b03 into master Apr 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/requirejs-timeout branch April 3, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants