Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align contents of tarball from 'make appstore' and 'make dist' #302

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Nov 26, 2019

fixes issue #300

  1. remove other various CI and code-analysis-related files for the make appstore tarball.
  2. remove little rubbish from l10n folder for the make dist tarball.

This gets the 2 tarballs to have the same contents.

@phil-davis
Copy link
Contributor Author

At least this aligns the 2 ways to make the tarball. Someone else can decide if we want to keep both appstore and dist targets, or if we delete one of them.

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #302 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #302   +/-   ##
========================================
  Coverage      5.24%   5.24%           
  Complexity      321     321           
========================================
  Files            14      14           
  Lines          1201    1201           
========================================
  Hits             63      63           
  Misses         1138    1138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4158532...8712511. Read the comment docs.

@phil-davis
Copy link
Contributor Author

@timar @micbar or anyone - this is ready for review.

@micbar micbar merged commit 2782721 into master Nov 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the align-make-appstore-dist branch November 27, 2019 16:24
@phil-davis phil-davis mentioned this pull request Nov 29, 2019
@phil-davis phil-davis mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants