Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not offer an update if PHP version doesn't match #356

Open
PVince81 opened this issue Jun 24, 2016 · 5 comments
Open

Do not offer an update if PHP version doesn't match #356

PVince81 opened this issue Jun 24, 2016 · 5 comments

Comments

@PVince81
Copy link
Contributor

The updater (or update server ?) should not propose an update if the PHP version of the new ownCloud version is not compatible with the current one.

The goal is to avoid being in a "stuck" situation where someone might not be able to update their PHP version (shared hoster?) but then the source code has already been replaced and they have to restore their backups.

@VicDeo

@VicDeo
Copy link
Member

VicDeo commented Jun 24, 2016

@PVince81 err. I'd say even more: check all requirements against update server.

@ghost
Copy link

ghost commented Jul 9, 2016

This was implemented for quite some time for PHP 5.4 and Windows in #107

But such hardcoded stuff is quite inflexible so the check on update server side is probably the best approach.

@VicDeo
Copy link
Member

VicDeo commented Aug 9, 2016

@PVince81 what do you think about extending update server with appinfo.xml-alike <dependencies> tag?

@VicDeo
Copy link
Member

VicDeo commented Aug 9, 2016

something like that:

<owncloud>
     <version>9.0.4</version>
     <versionstring>ownCloud 9.0.4</versionstring>
     <url>https://download.owncloud.org/community/owncloud-9.0.4.zip</url>
    <web>https://doc.owncloud.org/server/9.0/admin_manual/maintenance/upgrade.html</web>
    <dependencies>
        <php min-version="5.4" max-version="7.0" />
    </dependencies>
</owncloud>

@PVince81
Copy link
Contributor Author

PVince81 commented Aug 9, 2016

@VicDeo more like adding a new field to the update server's PHP config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants