Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill DbUpgradeCommand - not an updater responsibility #420

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Kill DbUpgradeCommand - not an updater responsibility #420

merged 1 commit into from
Mar 21, 2017

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Mar 21, 2017

It was never used anyway

@VicDeo VicDeo added this to the 10.0 milestone Mar 21, 2017
@PVince81
Copy link
Contributor

👍

I guess the DB upgrade is run as part of another step then ?

@VicDeo
Copy link
Member Author

VicDeo commented Mar 21, 2017 •
edited
Loading

@PVince81 there are a lot different issues against updater across all repos.
One of them is #304 that says that database upgrade should be done in core within occ upgrade. Thus, Updater shouldn't touch DB.

This command was added in advance and was not executed. it's a stinky dead code.

@VicDeo VicDeo merged commit 8ee1ef9 into master Mar 21, 2017
@VicDeo VicDeo deleted the kill-dbupgrade branch March 21, 2017 19:02
@VicDeo VicDeo mentioned this pull request May 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@VicDeo @PVince81