Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal "app context" top bar #8422

Closed
dragotin opened this issue Feb 13, 2023 · 5 comments · Fixed by #8447
Closed

Universal "app context" top bar #8422

dragotin opened this issue Feb 13, 2023 · 5 comments · Fixed by #8447

Comments

@dragotin
Copy link
Contributor

when opening a file in a viewer or editor in ownCloud web, it should display an area in the top bar that shows the file name, a "three dot" menu offering actions of the editor, and possibly a close button that closes the editor.

The idea is to integrate that into the topmost darkblue bar of oC Web to not waste vertical space for that.

CERN has a prototype implementation that should be integrated into the product.

@tbsbdr @diocas @elizavetaRa

@diocas
Copy link
Contributor

diocas commented Feb 13, 2023

This is our prototype: cernbox@2f1d8a4

In practice, we don't use it (we have a not so pretty workaround) because we didn't have a way to import some missing components (like the context actions), into our own external applications.

@tbsbdr
Copy link
Contributor

tbsbdr commented Feb 14, 2023

Design polishing proposal

  • less dominant
  • no "Tab" mimic, because it is not a tab (no toggle with other tabs possible)
  • more aligned with the users visual memory

any objections?

Current

image

Proposal

image

Users visual memory shaped by

image

@diocas
Copy link
Contributor

diocas commented Feb 15, 2023

I like it, but maybe it's too understated? Could we put a very light background around it? (not necessarily looking like a browser tab, but nowadays tabs have different visual styles, so I'm not sure what we can do to avoid it)

@elizavetaRa
Copy link
Member

@tbsbdr I suggest the configurable app context bar background, you can leave it unset, we'd like to have it a little different from the background color. We'll try to implement towards this idea.
Also configurable setting for file icon as a suggestion. We reuse oc-resource where it's given by default
Screenshot from 2023-02-15 16-24-46

@tbsbdr
Copy link
Contributor

tbsbdr commented Feb 22, 2023

  • jup, configurable background is a good idea 👍
  • if the configurable app-icon is < 60 mins effort I'd go with it @pascalwengerter

Default impression for the product should be a discreet top-bar, i.e. default: no tab-style, no icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants