Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser hangs when selecting a lot of users in admin-settings #9048

Closed
tschiebel opened this issue May 16, 2023 · 10 comments
Closed

Browser hangs when selecting a lot of users in admin-settings #9048

tschiebel opened this issue May 16, 2023 · 10 comments
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@tschiebel
Copy link

Error description

Browser hangs.

Steps to reproduce

Steps to reproduce the behavior:

  • All 1239 users of a instance (0183) selected.
  • Edit login as batch.
  • Attempt to select "NO

Expected behavior

All users can be deactivated by batch.

Actual behavior

All users were selected after a long wait. However, the NO could not be clicked.

Additional context

Epic says that the deployment is not yet complete, but the feature is available and also usable:
With smaller number (class with about 30 users) you could do the batch processing to deactivate and also to activate the login.

image
image
image

Comment

Browser crashes are annoying, but here the system was really challenged. However, I suspect that the instance 0183 itself (i.e. not only my browser frontend) was also damaged by this, because uploads of files failed afterwards (message for this is "unknown error"). The two screenshots with the filename Screenshot*.png in the attachment of this ticket could not be uploaded on 0183 anymore. The upload on instance 0146, on the other hand, worked.

@tschiebel tschiebel added the Type:Bug Something isn't working label May 16, 2023
@micbar micbar transferred this issue from owncloud/ocis May 16, 2023
@micbar
Copy link
Contributor

micbar commented May 16, 2023

@kulmann @janackermann we need to see what is feasible.

@kulmann kulmann changed the title Browser hangs Browser hangs when selecting a lot of users in admin-settings May 16, 2023
@kulmann kulmann added the Priority:p2-high Escalation, on top of current planning, release blocker label May 16, 2023
@JammingBen
Copy link
Collaborator

JammingBen commented May 16, 2023

We re-fetch each user after the operation to ensure the data is up to date with the server. We could skip that, which would reduce the amount of outgoing requests by half. Instead we could simply re-load the users list. The only drawback I see here: the current selection gets lost. @kulmann What do you think?

Edit: Nevermind, I think I misunderstood the issue. The issue is that the options in the dropdown are not selectable because the browser hangs, right? The screenshots are way to small to see anything unfortunately.

@kulmann
Copy link
Member

kulmann commented May 16, 2023

@JammingBen we also fetch each user individually (because we need to expand the drive data) upon selection. So things are going crazy even before any batch action is triggered.

Currently thinking about limiting the number of listed users to some amount (100? 200?) and enforce filtering with this. Maybe even show an empty list until filters have been applied.

@JammingBen
Copy link
Collaborator

JammingBen commented May 16, 2023

True... although it makes me wonder why the dropdown-selection in the modal does not work after all users have been selected successfully 🤔 Either way, 1000+ rows per page without any pagination or lazy loading probably break the page under any circumstance.

@AlexAndBear
Copy link
Contributor

Exactly, we've talked a long while ago about server-side pagination, but not been implemented...

Client-side pagination is the way to go for now IHMO

@tbsbdr
Copy link
Contributor

tbsbdr commented May 23, 2023

yes, lets try a client side pagination / limit as temporary workaround with 200 max selected items.

@AlexAndBear
Copy link
Contributor

@tbsbdr does this applies to all tables in admin-settings-app ? I vote for yes

@kulmann
Copy link
Member

kulmann commented May 23, 2023

@tbsbdr does this applies to all tables in admin-settings-app ? I vote for yes

Yes, please in a consistent way for all three that we have.

@AlexAndBear
Copy link
Contributor

@tbsbdr talked with involved web team members -> 50 items per page seems to be quite reasonable

@JammingBen
Copy link
Collaborator

Not technically fixed, but mitigated by #9119, so I'm closing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants