Fix search context menu #6445
Merged
Fix search context menu #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/22825/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-16-06-08-35.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-shares-file-to-brian-alice-2022-2-16-06-09-54.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-shares-file-to-brian-brian-2022-2-16-06-09-59.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-shares-folder-with-file-to-brian-alice-2022-2-16-06-11-07.zip |
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/22825/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-16-06-09-35.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-shares-file-to-brian-alice-2022-2-16-06-11-01.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-shares-file-to-brian-brian-2022-2-16-06-11-06.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22825/alice-shares-folder-with-file-to-brian-alice-2022-2-16-06-12-19.zip |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/22827/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-16-06-52-17.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-shares-file-to-brian-alice-2022-2-16-06-53-36.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-shares-file-to-brian-brian-2022-2-16-06-53-40.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-shares-folder-with-file-to-brian-alice-2022-2-16-06-54-49.zip |
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/22827/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-16-06-53-28.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-shares-file-to-brian-alice-2022-2-16-06-54-58.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-shares-file-to-brian-brian-2022-2-16-06-55-04.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22827/alice-shares-folder-with-file-to-brian-alice-2022-2-16-06-56-18.zip |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/22830/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-16-07-30-59.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-shares-file-to-brian-alice-2022-2-16-07-32-20.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-shares-file-to-brian-brian-2022-2-16-07-32-25.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-shares-folder-with-file-to-brian-alice-2022-2-16-07-33-34.zip |
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/22830/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-16-07-31-49.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-shares-file-to-brian-alice-2022-2-16-07-33-15.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-shares-file-to-brian-brian-2022-2-16-07-33-20.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22830/alice-shares-folder-with-file-to-brian-alice-2022-2-16-07-34-33.zip |
kulmann
requested changes
Feb 16, 2022
packages/web-app-files/src/components/FilesList/ContextActions.vue
Outdated
Show resolved
Hide resolved
dschmidt
force-pushed
the
fix_search_context_menu
branch
4 times, most recently
from
00cedc3
to
e3eb3d7
Compare
dschmidt
force-pushed
the
fix_search_context_menu
branch
from
e3eb3d7
to
09f154b
Compare
kulmann
requested changes
Feb 16, 2022
dschmidt
force-pushed
the
fix_search_context_menu
branch
from
df3e462
to
240d2ea
Compare
dschmidt
force-pushed
the
fix_search_context_menu
branch
from
240d2ea
to
33ef769
Compare
|
SonarCloud Quality Gate failed. |
|
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22843/66/1
|
|
🤩 |
dschmidt
added a commit
that referenced
this pull request
Feb 18, 2022
In #6445 we introduced a dependency on isFilesAppActive for the fileActions mixin. We added it to ContextActions and BatchActions, but there are way more places where the mixin is used. That's why we added a computed to the mixin itself. Because mixins belong to the options api we unfortunately cannot use composables directly and extracted helper functions for that reason.
dschmidt
added a commit
that referenced
this pull request
Feb 18, 2022
In #6445 we introduced a dependency on isFilesAppActive for the fileActions mixin. We added it to ContextActions and BatchActions, but there are way more places where the mixin is used. That's why we add a computed to the mixin itself now. Because mixins belong to the options api we unfortunately cannot use composables directly and extracted helper functions for that reason.
dschmidt
added a commit
that referenced
this pull request
Feb 18, 2022
In #6445 we introduced a dependency on isFilesAppActive for the fileActions mixin. We added it to ContextActions and BatchActions, but there are way more places where the mixin is used. That's why we add a computed to the mixin itself now. Because mixins belong to the options api we unfortunately cannot use composables directly and extract helper functions for that reason.
10 tasks
dschmidt
added a commit
that referenced
this pull request
Feb 18, 2022
In #6445 we introduced a dependency on isFilesAppActive for the fileActions mixin. We added it to ContextActions and BatchActions, but there are way more places where the mixin is used. That's why we add a computed to the mixin itself now. Because mixins belong to the options api we unfortunately cannot use composables directly and extract helper functions for that reason.
dschmidt
added a commit
that referenced
this pull request
Feb 18, 2022
In #6445 we introduced a dependency on isFilesAppActive for the fileActions mixin. We added it to ContextActions and BatchActions, but there are way more places where the mixin is used. That's why we add a computed to the mixin itself now. Because mixins belong to the options api we unfortunately cannot use composables directly and extract helper functions for that reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable/disable certain file actions outside of the file application.
Related Issue
Motivation and Context
Several file actions (currently) work or don't work outside the files app. In general anything that just interacts with the backend works fine, actions that rely on e.g., the sidebar, don't work in the search app for instance.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks:
Decide whether we want to make the search results selectable in the ResourcesTable, to prepare for multi select and archive download.
Currently we have no search in oCIS and
isDownloadAsArchiveAvailableis false on oC 10, so currently it's probably just confusing for no benefit... tying this toisDownloadAsArchiveAvailablewould be possible, but feels weird as well ... happy to hear other opinions :)Adding a check whether