Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable tours #7096

Closed
wants to merge 4 commits into from
Closed

Conversation

elizavetaRa
Copy link
Member

@elizavetaRa elizavetaRa commented Jun 8, 2022

Description

Configurable tours

Following implemented:

  • Property "tours" in "options" in config.js for linking json files for tours saved in packages/web-runtime/tours
    Example: "options": {"tours": ["https://localhost:9200/tours/tour1.json", "https://localhost:9200/tours/tour2.json"],..}

  • Each json file in packages/web-runtime/tours is considered as a tour and has the following properties:

    • translations: object with language codes as keys and translatable tour options (tourName, tooltip, steps) as values
    • options of tour from shepherd.js
    • autostart option including location (route name) and timeout in ms to trigger. Only triggering once (when triggered, saved to localStorage)
    • allowLocations option: array with locations in which the tour will be available. If set, the tour will not be available in other locations
    • denyLocations option: array with locations in which the tour will not be available. If set is not set, the tour will be available in all locations except of these locations. Is not considered if allowLocations is set
  • By one tour the button in the topbar will be the button to start this tour, by several the component will be shown

  • Buttons inside each step have hard-coded options "back", `"next"

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:

Screenshots:

tours

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • automatize showing buttons "next" and "back"
  • implement the possibility to attach events to steps

@update-docs
Copy link

update-docs bot commented Jun 8, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@elizavetaRa elizavetaRa force-pushed the upstream_guide branch 4 times, most recently from c606833 to 689d1ea Compare June 13, 2022 08:22
@elizavetaRa
Copy link
Member Author

@pascalwengerter @fschade @kulmann please check the implementation and add ideas
@tbsbdr critique, ideas from you?

@diocas
Copy link
Contributor

diocas commented Dec 19, 2022

Btw, @kulmann I believe this PR can be closed. I've adapted it to an external extension by using the vue portal library you also use: cernbox@6215548
Would this make sense for you as a way of personalising the top bar?

@dschmidt dschmidt mentioned this pull request Dec 19, 2022
30 tasks
@dschmidt
Copy link
Member

I've added a link to your idea/suggestion to our Extension System Epic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants