Add header to the sidebar in spaces management #8234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
JammingBen
force-pushed
the
spaces-management-sidebar-header
branch
from
6bb61bd
to
7dbd7df
Compare
JammingBen
force-pushed
the
spaces-management-sidebar-header
branch
from
983f761
to
b26d0bd
Compare
JammingBen
force-pushed
the
spaces-management-sidebar-header
branch
from
b26d0bd
to
b8ae606
Compare
dschmidt
approved these changes
Jan 13, 2023
|
|
||
| export default defineComponent({ | ||
| name: 'SpaceInfo', | ||
| props: { | ||
| spaceResource: { |
There was a problem hiding this comment.
Don't we call the prop just space usually?
There was a problem hiding this comment.
It's kinda all over the place. A lot of these space sidebar components have a computed prop space, so we do this to avoid name clashing.
There was a problem hiding this comment.
Wouldn't it make more sense to have a consistent space var name in public component API (here: in props) and whatever other var name for internal use?
There was a problem hiding this comment.
Yeah, at least we keep the API consistent this way. But I'd do this in a follow-up as well, as it probably touches more components.
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Types of changes