Fix group avatar display in space members list #8248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
reviewed
Jan 16, 2023
packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue
Outdated
Show resolved
Hide resolved
kulmann
force-pushed
the
fix-space-member-group-avatar
branch
5 times, most recently
from
8fdea1a
to
7e7671d
Compare
|
PR is ready for review now. Can't review myself anymore because I took over the dev part. :-) |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/32278/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32278/tracing/participant-management-alice-2023-1-31-08-44-17.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32278/tracing/participant-management-brian-2023-1-31-08-44-26.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32278/tracing/participant-management-marie-2023-1-31-08-44-30.zip |
kulmann
force-pushed
the
fix-space-member-group-avatar
branch
from
7e7671d
to
72c1c7a
Compare
kulmann
force-pushed
the
fix-space-member-group-avatar
branch
from
72c1c7a
to
cf16206
Compare
|
SonarCloud Quality Gate failed. |
|
LGTM, but I can't approve the changes since it's my PR :( |
kulmann
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The solution is not super straight-forwarded currently, unfortunately... We need to check for the presence of
collaborator.nameas space group shares don't have that property. We can't check for the share type because all user- and group-shares for spaces have the exact same share type.Edit: we've introduced a
shareType 8for groups as space members. With that it's pretty much straightforward now.Related Issue
Types of changes
Open tasks