Waypoints import (.OTRW) reports "import failed"

[jpmens]

• App build number: 2.4.10 (20410033)
• Android version: 9
• Device: Samsung S8
• Installation source: Google Play

As reported in #1282, the import of an .otrw file containing waypoints fails with the diagnostic Import failed: message is not a valid configuration message

This is the JSON:

{
	"_type": "waypoints",
	"waypoints": [
		{
			"_type": "waypoint",
			"desc": "Chez Jane à Paris",
			"lat": 48.856826,
			"lon": 2.292713,
			"rad": 450,
			"tst": 1598451372
		},
		{
			"_type": "waypoint",
			"desc": "Lestari Indonesisch restaurant",
			"lat": 51.978743,
			"lon": 5.905338,
			"rad": 100,
			"tst": 1598453157
		}
	]
}

As far as I can tell, this worked in August 2020 which was when I last tested this import.

[growse]

Hm. I don't remember being able to import a waypoint list JSON file via the configuration import ever worked. Is that a thing that should work? Would having the option of importing via the "Regions" activity not be more intuitive?

That error is coming from this bit of code, which is definitely only considering _type=configuration to be a valid configuration to import:

android/project/app/src/main/java/org/owntracks/android/ui/preferences/load/LoadViewModel.java

Lines 62 to 79 in d373b8e

	private void setConfiguration(String json) throws IOException, Parser.EncryptionException {
	MessageBase message = parser.fromJson(json.getBytes());
	if (message instanceof MessageConfiguration) {
	this.configuration = (MessageConfiguration) parser.fromJson(json.getBytes());
	String prettyConfiguration;
	try {
	prettyConfiguration = parser.toUnencryptedJsonPretty(this.configuration);
	} catch (IOException e) {
	Timber.e(e);
	prettyConfiguration = "Unable to parse configuration";
	}
	displayedConfiguration = prettyConfiguration;
	importStatus = ImportStatus.SUCCESS;
	notifyChange();
	} else {
	throw new IOException("Message is not a valid configuration message");
	}
	}

[jpmens]

I would have sworn it worked but have been wrong before, and if the code isn't there, then I'm definitely wrong!

importing via the "Regions" activity

Will you educate me? What is that?

[growse]

This one:

[jpmens]

Ah, you speak of a possible future; being able to import regions there.

Our iOS app permits import of waypoints as specified above via import (association with the app) of *.otrw (the w is for waypoints) files. I think we decided that several years ago, and the intention was to have this equivalent in both Android and iOS. It seems #14 actually led to an implementation in #596 (at least it says 'fixed'), but I don't see code for it ...

[growse]

All futures are possible! 😄

Ok, so if this doesn't work today, is it better to spend time making it work on the configuration import screen, or is it better to actually implement it in the regions screen (which is arguably where it belongs)?

[ckrey]

In iOS, the import is not a function of the app, but the filetype .otrw is opened with the app automatically.
From this point of view, I don't have a preference for the screen.

Does the import of waypoints via cmd work in Android as in #596?
https://owntracks.org/booklet/tech/json/#_typecmd

[growse]

Does the import of waypoints via cmd work in Android as in #596?
https://owntracks.org/booklet/tech/json/#_typecmd

Yes, this works.