add some more (slightly of the codebase changed) speedups #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owobred
changed the title
Alexejhero
reviewed
Jun 7, 2023
Comment on lines
-55
to
+56
| to_concatenate = np.array([convert_type(padding_value()) if callable(padding_value) else convert_type(padding_value) for _ in range(len(lst), length)]) | ||
| padding = convert_type(padding_value()) if callable(padding_value) else convert_type(padding_value) | ||
| to_concatenate = np.array([padding for _ in range(len(lst), length)]) |
There was a problem hiding this comment.
This defeats the purpose of having padding_value be a callable. We don't want to reuse the same instance of the padding value, that's why we we pass in a callable as the argument. Unless something has changed since I wrote the code originally, reusing the same instance of that padding value might break some stuff.
Comment on lines
-66
to
+68
| l = np.array([convert_type(padding_value()) if callable(padding_value) else convert_type(padding_value) for _ in range(length)]) | ||
| padding = convert_type(padding_value()) if callable(padding_value) else convert_type(padding_value) | ||
| l = np.array([padding for _ in range(length)]) |
Alexejhero
reviewed
Jun 7, 2023
Comment on lines
+63
to
+80
| type_mapping: list[tuple[typing.Type, typing.Callable]] = [ | ||
| (bool, convert_bool), | ||
| (dict, convert_dict), | ||
| (list, convert_list), | ||
| (str, convert_str), | ||
| (PositionData, convert_positiondata), | ||
| (TaskData, convert_taskdata), | ||
| (Vector2, convert_vector2), | ||
| (betterproto.Message, convert_message), | ||
| (betterproto.Enum, convert_enum), | ||
| (int, lambda x: [x]), | ||
| (float, lambda x: [x]), | ||
| (np.ndarray, lambda x: convert_list(x.tolist())), | ||
| ] | ||
|
|
||
| #print(extra_info) | ||
|
|
||
| for cls, func in type_mapping.items(): | ||
| for cls, func in type_mapping: |
There was a problem hiding this comment.
If this is faster though you can include it in the other pr
|
ty @Alexejhero, was unsure if these would have a negative effect in places given I didn't have much experience. The other speedup in this pr has very little benefit compared to this part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I'm using another device so these numbers aren't relative to the timings)
Current speedups
With a list of tuples instead of a dict
Re-using values in
pad_list