Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions in CONTRIBUTING.md for adding upstream remote #22

Closed
ows-ali opened this issue Oct 17, 2018 · 5 comments
Closed

Add instructions in CONTRIBUTING.md for adding upstream remote #22

ows-ali opened this issue Oct 17, 2018 · 5 comments
Labels
enhancement New feature or request first-timers-only good first issue Good for newcomers Hacktoberfest For Hacktoberfest participants to win a T-Shirt help wanted Extra attention is needed low hanging fruit easy to contribute starter up for grabs open to many

Comments

@ows-ali
Copy link
Owner

ows-ali commented Oct 17, 2018

Add upstream instructions, so contributors can resolve more issues themselves when there fork is behind the repo's master or if there is any merge conflict.
@ows-ali ows-ali added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest For Hacktoberfest participants to win a T-Shirt up for grabs open to many low hanging fruit easy to contribute labels Oct 17, 2018
@seancyw
Copy link
Contributor

seancyw commented Oct 17, 2018

@ows-ali ,
I will grab this as well. Thanks.

@ows-ali
Copy link
Owner Author

ows-ali commented Oct 18, 2018

Sure @seancyw, please add your name in Contributors list as well 😊

seancyw added a commit to seancyw/Hacktoberfest that referenced this issue Oct 20, 2018
@seancyw
Adding instruction for adding upstream remote ows-ali#22
bbf1ba1
@seancyw
Copy link
Contributor

seancyw commented Oct 20, 2018

@ows-ali ,
the changes is updated. Please check and merged the changes if no further comment. :)

@ows-ali
Copy link
Owner Author

ows-ali commented Oct 20, 2018

@seancyw great work. And somewhat different from what I will do. Like for step 2 I will do git pull from upstream and then make any changes and git push origin master.
But both works.
Can you please make a small change? It is not necessary to use master branch in forked repo as you mentioned in Step 3, so can you add that they can use master or their own new branch?

ows-ali added a commit that referenced this issue Oct 21, 2018
@ows-ali
Merge pull request #92 from seancyw/master
81ad26d 
Closing issues #22
@ows-ali ows-ali mentioned this issue Oct 21, 2018
Merged
@ows-ali ows-ali closed this as completed Oct 21, 2018
@ows-ali
Copy link
Owner Author

ows-ali commented Oct 21, 2018

Thanks for resolving the issue @seancyw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request first-timers-only good first issue Good for newcomers Hacktoberfest For Hacktoberfest participants to win a T-Shirt help wanted Extra attention is needed low hanging fruit easy to contribute starter up for grabs open to many
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seancyw @ows-ali