-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch stable channel more precisely #166
Conversation
Add cron that will catch stable releases more precisely.
.github/workflows/sync-channels.yaml
Outdated
# The stable channel is usually updated before 17:00:00 UTC | ||
- cron: '0 17 * * *' # *-*-* 17:00:00 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any references or evidences? Seems they do not mention anything about the scheduled time in https://forge.rust-lang.org/release/process.html#release-day-thursday.
Also it seems to be always on Thursday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is based on observations and looking at rust release calendar: https://calendar.google.com/calendar/ical/mozilla.com_ts4qudb88i0tbjef8rche4a6v4@group.calendar.google.com/public/basic.ics, and because stable release is done every 6 weeks, this means it happens every Thursday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is based on observations and looking at rust release calendar:
That link shows an event on UTC 1700-1800, is it the time they click the release button or only started the CI jobs?
I checked the last-modified time of the channel TOML, which seems to be fairly random:
$ curl --silent https://static.rust-lang.org/dist/channel-rust-1.{71..78}.toml --head | rg last-modified
last-modified: Thu, 03 Aug 2023 18:06:55 GMT
last-modified: Tue, 19 Sep 2023 14:02:18 GMT
last-modified: Thu, 05 Oct 2023 16:06:42 GMT
last-modified: Thu, 07 Dec 2023 14:17:53 GMT
last-modified: Thu, 28 Dec 2023 16:17:53 GMT
last-modified: Thu, 08 Feb 2024 14:02:51 GMT
last-modified: Tue, 09 Apr 2024 21:35:05 GMT
last-modified: Thu, 02 May 2024 12:34:24 GMT
Or is there other historical records about the precise time of releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was checking github releases: https://github.com/rust-lang/rust/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That link shows an event on UTC 1700-1800, is it the time they click the release button or only started the CI jobs?
Builds happen way prior that's just target time that all work is pushed through AFAIK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the last-modified time of the channel TOML, which seems to be fairly random
dot releases are more chaotic as they are done on as needed basis (so they are outlines).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the last-modified time of the channel TOML, which seems to be fairly random
dot releases are more chaotic as they are done on as needed basis (so they are outlines).
The point zero releases are not as stable as you mentioned either.
$ curl --silent https://static.rust-lang.org/dist/channel-rust-1.{71..78}.0.toml --head | rg last-modified
last-modified: Thu, 13 Jul 2023 13:59:35 GMT
last-modified: Thu, 24 Aug 2023 13:42:47 GMT
last-modified: Thu, 05 Oct 2023 16:06:42 GMT
last-modified: Thu, 16 Nov 2023 13:45:13 GMT
last-modified: Thu, 28 Dec 2023 16:17:50 GMT
last-modified: Thu, 08 Feb 2024 14:02:51 GMT
last-modified: Thu, 21 Mar 2024 12:53:00 GMT
last-modified: Thu, 02 May 2024 12:34:25 GMT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But they are all before 17:00. Sometimes there are also last minute fixes to rc version.
run only on Thursday
This is best-effort anyway, it doesn't cost anything, we just try to do our best to get stable versions sooner. |
Instead of bikeshed over the exact timing maybe we could just run this multiple times per day? It's a bummer to wait 24h no matter when the new rust release ships. And, action runs are cheap overall especially for open projects. |
Thank you @oxalica!! |
Thank you! We are in JST timezone so we usually end up seeing a release in morning and then having to wait few hours to use it... |
Add cron that will catch stable releases more precisely.