Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch stable channel more precisely #166

Closed
wants to merge 2 commits into from
Closed

Conversation

sagudev
Copy link

@sagudev sagudev commented May 2, 2024

Add cron that will catch stable releases more precisely.

Add cron that will catch stable releases more precisely.
Comment on lines 6 to 7
# The stable channel is usually updated before 17:00:00 UTC
- cron: '0 17 * * *' # *-*-* 17:00:00 UTC
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any references or evidences? Seems they do not mention anything about the scheduled time in https://forge.rust-lang.org/release/process.html#release-day-thursday.

Also it seems to be always on Thursday.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on observations and looking at rust release calendar: https://calendar.google.com/calendar/ical/mozilla.com_ts4qudb88i0tbjef8rche4a6v4@group.calendar.google.com/public/basic.ics, and because stable release is done every 6 weeks, this means it happens every Thursday.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on observations and looking at rust release calendar:

That link shows an event on UTC 1700-1800, is it the time they click the release button or only started the CI jobs?

I checked the last-modified time of the channel TOML, which seems to be fairly random:

$ curl --silent https://static.rust-lang.org/dist/channel-rust-1.{71..78}.toml --head | rg last-modified
last-modified: Thu, 03 Aug 2023 18:06:55 GMT
last-modified: Tue, 19 Sep 2023 14:02:18 GMT
last-modified: Thu, 05 Oct 2023 16:06:42 GMT
last-modified: Thu, 07 Dec 2023 14:17:53 GMT
last-modified: Thu, 28 Dec 2023 16:17:53 GMT
last-modified: Thu, 08 Feb 2024 14:02:51 GMT
last-modified: Tue, 09 Apr 2024 21:35:05 GMT
last-modified: Thu, 02 May 2024 12:34:24 GMT

Or is there other historical records about the precise time of releases?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking github releases: https://github.com/rust-lang/rust/releases

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That link shows an event on UTC 1700-1800, is it the time they click the release button or only started the CI jobs?

Builds happen way prior that's just target time that all work is pushed through AFAIK.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the last-modified time of the channel TOML, which seems to be fairly random

dot releases are more chaotic as they are done on as needed basis (so they are outlines).

Copy link
Owner

@oxalica oxalica May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the last-modified time of the channel TOML, which seems to be fairly random

dot releases are more chaotic as they are done on as needed basis (so they are outlines).

The point zero releases are not as stable as you mentioned either.

$ curl --silent https://static.rust-lang.org/dist/channel-rust-1.{71..78}.0.toml --head | rg last-modified
last-modified: Thu, 13 Jul 2023 13:59:35 GMT
last-modified: Thu, 24 Aug 2023 13:42:47 GMT
last-modified: Thu, 05 Oct 2023 16:06:42 GMT
last-modified: Thu, 16 Nov 2023 13:45:13 GMT
last-modified: Thu, 28 Dec 2023 16:17:50 GMT
last-modified: Thu, 08 Feb 2024 14:02:51 GMT
last-modified: Thu, 21 Mar 2024 12:53:00 GMT
last-modified: Thu, 02 May 2024 12:34:25 GMT

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But they are all before 17:00. Sometimes there are also last minute fixes to rc version.

run only on Thursday
@sagudev
Copy link
Author

sagudev commented May 29, 2024

This is best-effort anyway, it doesn't cost anything, we just try to do our best to get stable versions sooner.

@iterion
Copy link

iterion commented Sep 5, 2024

Instead of bikeshed over the exact timing maybe we could just run this multiple times per day? It's a bummer to wait 24h no matter when the new rust release ships. And, action runs are cheap overall especially for open projects.

@oxalica oxalica closed this in 6bf986d Sep 5, 2024
@iterion
Copy link

iterion commented Sep 6, 2024

Thank you @oxalica!!

@Fuuzetsu
Copy link

Fuuzetsu commented Sep 6, 2024

Thank you! We are in JST timezone so we usually end up seeing a release in morning and then having to wait few hours to use it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants