Major update #25
Merged
Major update #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should add support for IPv6.
This prevents dropped data if a write to a client is cut short. Move default port number to config schema
Co-authored-by: Joshua Spence <josh@joshuaspence.com>
This was referenced Feb 3, 2023
Closed
Closed
oxan
commented
Feb 3, 2023
| // Only warn on the first iteration, the finite buffer size is also used as a throttling mechanism to avoid | ||
| // blocking here for too long when a large amount of data comes in. | ||
| if (first_iteration) | ||
| ESP_LOGW(TAG, "Incoming bytes available in stream, but outgoing buffer is full!"); |
There was a problem hiding this comment.
We should probably overwrite data instead of dropping data: if there are multiple clients, that means only the straggler will have problems, instead of all clients. It also prevents the possibility of lockups.
|
Also needs a documentation update, and a declaration of the minimum required ESPHome version. |
oxan
force-pushed
the
socket-abstraction
branch
from
9b111b1
to
9710568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send_buffor high throughput #4, but with proper handling for multiple clients.binary_sensor#15 but refactored to not publish a state on everyloop().Still needs some more testing (especially w.r.t. reliability), but should be complete code-wise.