feat!: remove the constraint on packages exports default must be the last one
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #171 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 96.89% 96.87% -0.02%
==========================================
Files 11 11
Lines 2283 2275 -8
==========================================
- Hits 2212 2204 -8
Misses 71 71 ☔ View full report in Codecov by Sentry. |
…e last one closes #160 The spec never mentioned the logic where "default" must be last or it should throw an error. https://nodejs.org/api/esm.html#resolution-and-loading-algorithm `enhanced-resolve` took the meaning from https://nodejs.org/docs/v20.13.1/api/packages.html#conditional-exports "This condition should always come last." This statement is not part of the specification, it is a recommendation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #160
The spec never mentioned the logic where "default" must be last or it should throw an error.
https://nodejs.org/api/esm.html#resolution-and-loading-algorithm
enhanced-resolvetook the meaning from https://nodejs.org/docs/v20.13.1/api/packages.html#conditional-exports"This condition should always come last."
This statement is not part of the specification, it is a recommendation.