Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export package.json type and sideEffects field by default for bundlers #196

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jun 28, 2024

The fields are pretty small in size, but we can try and remove the clones if necessary.

…or bundlers

The fields are pretty small, but we can try and remove the clones if necessary.
Copy link

codspeed-hq bot commented Jun 28, 2024

CodSpeed Performance Report

Merging #196 will not alter performance

Comparing package-json-exports (42966d3) with main (9b9e97f)

Summary

✅ 2 untouched benchmarks

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.89%. Comparing base (9b9e97f) to head (42966d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   96.88%   96.89%           
=======================================
  Files          11       11           
  Lines        2281     2283    +2     
=======================================
+ Hits         2210     2212    +2     
  Misses         71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Boshen Boshen merged commit a3a2d24 into main Jun 28, 2024
21 checks passed
@Boshen Boshen deleted the package-json-exports branch June 28, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant