-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate CI filter for files included in oxc_ast_codegen
#4699
Comments
Can we just simplify it to: filters: |
src:
- 'crates/oxc_ast/src/**'
- 'crates/oxc_syntax/src/**'
- 'crates/oxc_span/src/**'
- 'tasks/ast_codegen/src/**' I know that casts the net a bit wider than it needs to, but:
|
If I'm not mistaken filter can be its own file, So we only generate a simple A simple generator not only makes sure that all of our current paths are being watched but it would also add new paths to the list as we extend upon it. That's why I felt it would be a good way to set it up and just forget about it. |
Ah OK. If it's that easy then, yes, seems like a good idea. |
I'm optimistic that it is quite trivial, I hope time doesn't prove me wrong😆 |
closes #4699 I also did some reordering to the code so it is easier to follow.
Implemented in #4737. |
Generate what files are watched, It is currently manually written here:
oxc/.github/workflows/ci.yml
Lines 277 to 284 in 82e2f6b
The text was updated successfully, but these errors were encountered: