Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): eslint-plugin-unicorn/no-abusive-eslint-disable #1125

Merged
merged 5 commits into from
Nov 12, 2023

Conversation

haocheng6
Copy link
Contributor

@github-actions github-actions bot added the A-linter Area - Linter label Oct 31, 2023
Copy link

codspeed-hq bot commented Oct 31, 2023

CodSpeed Performance Report

Merging #1125 will not alter performance

Comparing haocheng6:684-no-abusive-eslint-disable (398456c) with main (9aa78f6)

Summary

✅ 22 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Nov 1, 2023

Amazing work! Regarding performance:

Take a look at crates/oxc_linter/src/disable_directives.rs, we already have the disable comments parsed, should be easy to use it

https://github.com/web-infra-dev/oxc/blob/5a44c0918a7a261c7b3ef47100160eb4f8483554/crates/oxc_linter/src/context.rs#L19

@haocheng6
Copy link
Contributor Author

@Boshen Thanks for the pointer! I just made some changes to the rule to reuse parsed eslint-disable comments.

@Boshen Boshen merged commit 82c1769 into oxc-project:main Nov 12, 2023
17 checks passed
@Boshen
Copy link
Member

Boshen commented Nov 12, 2023

Thank you! Amazing work!

@haocheng6 haocheng6 deleted the 684-no-abusive-eslint-disable branch November 12, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants