Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): eslint-plugin-jest: no-hooks #1172

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

eryue0220
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the A-linter Area - Linter label Nov 6, 2023
Copy link

codspeed-hq bot commented Nov 6, 2023

CodSpeed Performance Report

Merging #1172 will degrade performances by 32.57%

Comparing eryue0220:feat/jest-no-hooks (d3f7e29) with main (9b66646)

Summary

❌ 4 regressions
✅ 18 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main eryue0220:feat/jest-no-hooks Change
linter[typescript.js] 15.1 s 18.7 s -19.54%
linter[vue.js] 691.4 ms 883.4 ms -21.73%
linter[antd.js] 8.4 s 10.4 s -19.59%
linter[react.development.js] 104.2 ms 154.5 ms -32.57%

@camc314
Copy link
Collaborator

camc314 commented Nov 6, 2023

do we want to port this one?
Looks like it isn't in the recommended set?

@Boshen
Copy link
Member

Boshen commented Nov 7, 2023

do we want to port this one? Looks like it isn't in the recommended set?

I want to ship recommended set for a more complete product, but merging in non-recommended rules is acceptable because the end goal is to have as many rules as we can. Clippy has more than 600 rules, we can probably reach 1000 😂

Copy link
Member

@mysteryven mysteryven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can ignore the benchmark, which is not related to this PR, just two nit picks above.😉

Copy link
Member

@mysteryven mysteryven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for your contribution, hope you enjoy it!

@mysteryven mysteryven merged commit 9369424 into oxc-project:main Nov 7, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants