-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): eslint-plugin-jest: no-hooks #1172
Conversation
CodSpeed Performance ReportMerging #1172 will degrade performances by 32.57%Comparing Summary
Benchmarks breakdown
|
do we want to port this one? |
I want to ship recommended set for a more complete product, but merging in non-recommended rules is acceptable because the end goal is to have as many rules as we can. Clippy has more than 600 rules, we can probably reach 1000 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can ignore the benchmark, which is not related to this PR, just two nit picks above.😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thanks for your contribution, hope you enjoy it!
No description provided.