-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): add jsx-a11y settings #1668
Conversation
Thank you for the PR! We now support reading from eslint config json! This means we can read values off https://www.npmjs.com/package/eslint-plugin-jsx-a11y#configurations I think you can read these values into a struct (deserialized) and then add it to |
@Boshen I check out the new code just now, let me read the settings from config json. |
@Boshen Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hashmap can be done with a follow up PR.
Continue to refine #1668
Added support for component settings for eslint-plugin-jsx-a11y no-distracting-elements rule based on #1668 PR. Updated the test cases.
When we developed linter for #1141 , we needed to configure some settings for
jsx-a11y
, which was not supported before, but I am trying to support it now.like this: