Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): introduce ThisParameter #1728

Merged
merged 8 commits into from
Dec 19, 2023
Merged

refactor(ast): introduce ThisParameter #1728

merged 8 commits into from
Dec 19, 2023

Conversation

magic-akari
Copy link
Collaborator

@magic-akari magic-akari commented Dec 18, 2023

Most TypeScript types can be eliminated during the code generation phase by not printing the corresponding AST nodes.
The changes in this PR enable applying a similar technique to the this parameter.

@github-actions github-actions bot added A-parser Area - Parser A-ast Area - AST A-transformer Area - Transformer / Transpiler labels Dec 18, 2023
@magic-akari magic-akari marked this pull request as ready for review December 18, 2023 12:53
@Boshen
Copy link
Member

Boshen commented Dec 18, 2023

This'll definitely help downstream tools. +1 from me.

@Boshen Boshen merged commit a2858ed into main Dec 19, 2023
17 checks passed
@Boshen Boshen deleted the ast/ts/this-param branch December 19, 2023 05:20
Boshen pushed a commit that referenced this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-parser Area - Parser A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants