Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(linter): use simd (memchr) for no-useless-escape search #1766

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 21, 2023

No description provided.

Copy link
Member Author

Boshen commented Dec 21, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added the A-linter Area - Linter label Dec 21, 2023
@Boshen Boshen requested a review from camc314 December 21, 2023 10:20
@Boshen
Copy link
Member Author

Boshen commented Dec 21, 2023

@camc314 This is pretty cool, you may use the same technique in other places 😁

@Boshen Boshen force-pushed the 12-21-perf_linter_use_simd_memchr_for_no-useless-escape_search branch from 3c11a1e to aaa0b7b Compare December 21, 2023 10:22
@Boshen Boshen force-pushed the 12-21-perf_linter_use_simd_memchr_for_no-useless-escape_search branch from aaa0b7b to 4095175 Compare December 21, 2023 10:38
@Boshen
Copy link
Member Author

Boshen commented Dec 21, 2023

The benchmark doesn't have enough strings.

@Boshen Boshen merged commit 2e707bc into main Dec 21, 2023
17 checks passed
@Boshen Boshen deleted the 12-21-perf_linter_use_simd_memchr_for_no-useless-escape_search branch December 21, 2023 11:14
@camc314
Copy link
Collaborator

camc314 commented Dec 26, 2023

@camc314 This is pretty cool, you may use the same technique in other places 😁

Yeah this is awesome 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants