refactor(parser): remove string builder from number parsing #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
CodSpeed Performance ReportMerging #2002 will not alter performanceComparing Summary
|
The builder was used to build an allocated string for numbers with underscores, this is no longer required because it is now allocated on demand. https://github.com/oxc-project/oxc/blob/0d77e1e788440ca4d5fe047ca4bdea7a01ed6210/crates/oxc_parser/src/lexer/number.rs#L32
Boshen
force-pushed
the
01-12-refactor_parser_remove_string_builder_from_number_parsing
branch
from
2ae1b8d
to
fac1308
Compare
Boshen
deleted the
01-12-refactor_parser_remove_string_builder_from_number_parsing
branch
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
…ect#2002) The builder was used to build an allocated string for numbers with underscores, this is no longer required because it is now allocated on demand. https://github.com/oxc-project/oxc/blob/0d77e1e788440ca4d5fe047ca4bdea7a01ed6210/crates/oxc_parser/src/lexer/number.rs#L32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builder was used to build an allocated string for numbers with
underscores, this is no longer required because it is now allocated on
demand.
oxc/crates/oxc_parser/src/lexer/number.rs
Line 32 in 0d77e1e