Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): remove noop code #2028

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

overlookmotel
Copy link
Collaborator

This PR removes some code from the lexer which doesn't do anything.

@github-actions github-actions bot added the A-parser Area - Parser label Jan 14, 2024
Copy link

codspeed-hq bot commented Jan 14, 2024

CodSpeed Performance Report

Merging #2028 will not alter performance

Comparing overlookmotel:lexer-remove-noop (9cf253c) with main (198f0e5)

Summary

✅ 14 untouched benchmarks

@Boshen Boshen merged commit b4d76f0 into oxc-project:main Jan 14, 2024
17 checks passed
@overlookmotel overlookmotel deleted the lexer-remove-noop branch January 14, 2024 16:10
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
This PR removes some code from the lexer which doesn't do anything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parser Area - Parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants