feat(linter): implement eslint(no-class-assign) #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangchenYe323
force-pushed
the
feat/no-class-assign
branch
from
0ad71c5
to
ba0e148
Compare
Boshen
reviewed
Mar 24, 2023
| // Class expression creates a temporary scope with the class name as its only variable | ||
| // E.g., `let c = class A { foo() { console.log(A) } }` | ||
| Some(ScopeFlags::empty()) | ||
| } |
There was a problem hiding this comment.
I need to lookup the spec for this one.
There was a problem hiding this comment.
This is an interesting case where TypeScript does a huge routine for this.
c gets the Class symbol while A gets an anonymous symbol ... it's really complicated. But your solution is fine here (for the foreseeable future.)
Boshen
approved these changes
Mar 24, 2023
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement no-class-assign