Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(oxc_parser): add header symbol for parser.unexpected's doc comment #24

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

jason89521
Copy link
Contributor

Description

It seems that there should exist a # symbol to make Panics be an title when user see the document comment.

Additional Information

I'm highly interested in this project, but I'm a newbie in Rust and compiler. Currently trying to understand the compiler concepts from the guide you wrote and trying to understand this great project :)

I'm also not good at english writing, so if I have written anything that offend you, please accept my apologies.

@jason89521 jason89521 marked this pull request as ready for review February 17, 2023 11:44
@Boshen Boshen closed this Feb 18, 2023
@Boshen Boshen reopened this Feb 18, 2023
@Boshen Boshen merged commit 362c02f into oxc-project:main Feb 18, 2023
@Boshen
Copy link
Member

Boshen commented Feb 18, 2023

(github on mobile is not easy to use so I accidentally closed this and then reopened again.)

Keep on learning, and we will see more contributions from you.

@jason89521 jason89521 deleted the docs/parser/markdown-header branch February 18, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants