-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): bad bitwise operator rule #246
feat(linter): bad bitwise operator rule #246
Conversation
So far so good, request a review when you are done. |
It's beyond my ability to implement type inference, I am not plan to do it in this PR, except it, It's ready for review. |
Amazing work! Thank you so much for working on a rule that doesn't have existing tests! |
I ran this in the VSCode repo, it seems people love to work on bitflag enums 🤔 I may have to demote this to another category later on. But it's fine for now. |
Another option is to only use this in js files. |
feat: #243
I had thought that if I wanted to implement the rule, I would have to implement all the detail of this rule, but I didn't find the source code of this rule, so I only implement the cases I can think of.
I didn't implement the part that requires type inference, it will all pass:
Maybe it is not the right implementation, any advice is welcome!