Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): improve the implementation of no_shadow_restricted_names based on symbols #2615

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 5, 2024

No description provided.

Copy link
Member Author

Dunqing commented Mar 5, 2024

@github-actions github-actions bot added the A-linter Area - Linter label Mar 5, 2024
@Dunqing Dunqing force-pushed the 03-05-feat_semantic_move_redeclare_varaibles_to_symbol_table branch from e705709 to bb7a88d Compare March 5, 2024 11:54
@Dunqing Dunqing force-pushed the 03-05-refactor_linter_improve_the_implementation_of_no_shadow_restricted_names_based_on_symbols branch from e53c041 to a66510a Compare March 5, 2024 11:54
@Dunqing Dunqing force-pushed the 03-05-feat_semantic_move_redeclare_varaibles_to_symbol_table branch from bb7a88d to e1ba6c7 Compare March 5, 2024 11:56
@Dunqing Dunqing force-pushed the 03-05-refactor_linter_improve_the_implementation_of_no_shadow_restricted_names_based_on_symbols branch 2 times, most recently from 4516fec to 158cc15 Compare March 5, 2024 11:58
@Dunqing Dunqing force-pushed the 03-05-feat_semantic_move_redeclare_varaibles_to_symbol_table branch from e1ba6c7 to c509242 Compare March 5, 2024 12:06
Copy link

codspeed-hq bot commented Mar 5, 2024

CodSpeed Performance Report

Merging #2615 will not alter performance

Comparing 03-05-refactor_linter_improve_the_implementation_of_no_shadow_restricted_names_based_on_symbols (679ac4c) with main (b2de57a)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 03-05-refactor_linter_improve_the_implementation_of_no_shadow_restricted_names_based_on_symbols branch from 158cc15 to f498d0d Compare March 5, 2024 12:06
@Dunqing Dunqing force-pushed the 03-05-feat_semantic_move_redeclare_varaibles_to_symbol_table branch from c509242 to b31e7a6 Compare March 6, 2024 04:34
Base automatically changed from 03-05-feat_semantic_move_redeclare_varaibles_to_symbol_table to main March 6, 2024 07:34
@Boshen
Copy link
Member

Boshen commented Mar 6, 2024

@Dunqing need a another rebase :-(

@github-actions github-actions bot added the A-semantic Area - Semantic label Mar 7, 2024
@Dunqing Dunqing force-pushed the 03-05-refactor_linter_improve_the_implementation_of_no_shadow_restricted_names_based_on_symbols branch 2 times, most recently from 7ea1e2d to 223bb09 Compare March 7, 2024 02:34
@Dunqing Dunqing force-pushed the 03-05-refactor_linter_improve_the_implementation_of_no_shadow_restricted_names_based_on_symbols branch from 223bb09 to 679ac4c Compare March 7, 2024 02:41
Copy link
Member

Boshen commented Mar 7, 2024

Merge activity

  • Mar 6, 9:51 PM EST: @Boshen started a stack merge that includes this pull request via Graphite.
  • Mar 6, 9:51 PM EST: @Boshen merged this pull request with Graphite.

@Boshen Boshen merged commit 47e735a into main Mar 7, 2024
23 checks passed
@Boshen Boshen deleted the 03-05-refactor_linter_improve_the_implementation_of_no_shadow_restricted_names_based_on_symbols branch March 7, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants